refactor(content): only call ~player_combat_stat on stat change and equipment change

[tannerdino]

Fairly certain they only need to be calculated on stat change and equipment change. I think there were also some osrs bugs related to this at some point with new weaponry?

Should also help with server tick speed :)

[tannerdino]

I noticed something that may be an issue.

Server/data/src/scripts/skill_combat/scripts/player/player_melee.rs2

Lines 29 to 36 in 8d52194

	def_int $damage = 0;
	if (~player_npc_hit_roll(%damagetype) = true) {
	if (npc_type = count_draynor & inv_total(inv, garlic) > 0) {
	%com_maxhit = add(%com_maxhit, 1);
	}
	if (npc_param(demonbane_vulnerable) = true & inv_total(worn, silverlight) > 0) {
	%com_maxhit = divide(multiply(%com_maxhit, 160), 100);
	}

Maxhit could exponentially increase if you never equip something or regenerate a stat. Maybe %com_maxhit is recalculated every hit. Perhaps %com_maxhit doesn't even exist? Is there a source for this?

[tannerdino]

I noticed something that may be an issue.

Server/data/src/scripts/skill_combat/scripts/player/player_melee.rs2

Lines 29 to 36 in 8d52194

	def_int $damage = 0;
	if (~player_npc_hit_roll(%damagetype) = true) {
	if (npc_type = count_draynor & inv_total(inv, garlic) > 0) {
	%com_maxhit = add(%com_maxhit, 1);
	}
	if (npc_param(demonbane_vulnerable) = true & inv_total(worn, silverlight) > 0) {
	%com_maxhit = divide(multiply(%com_maxhit, 160), 100);
	}

Maxhit could exponentially increase if you never equip something or regenerate a stat. Maybe %com_maxhit is recalculated every hit. Perhaps %com_maxhit doesn't even exist? Is there a source for this?

On second thought, perhaps a more simple answer is to just use a local variable or %int