feat(engine): allow custom debugproc char #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGould1
commented
Mar 1, 2025
| // minify: true, | ||
| // sourcemap: 'linked', | ||
| }).catch((e) => { throw new Error(e); }); | ||
| const bundle = await esbuild |
There was a problem hiding this comment.
My formatter has changed many of the files I touched, could this actually be correct though? I saw the project has a .prettierrc and I'm using prettier as my default formatter
There was a problem hiding this comment.
Yes, no worries, we have to run prettier over the whole codebase still to normalize it
Pazaz
reviewed
Mar 1, 2025
There was a problem hiding this comment.
Did you mean to commit this change to ::~random?
There was a problem hiding this comment.
oops :) no let me fix
There was a problem hiding this comment.
okay soz, fixed that
MattGould1
force-pushed
the
feature/allow-custom-debugproc
branch
from
abb5ed2 to
631112c
Compare
MattGould1
changed the title
kylmp
reviewed
Mar 1, 2025
Co-authored-by: kylmp <14829626+kylmp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a custom debugproc char (some people don't have easy access to
~)Also removes
NODE_ALLOW_CHEATSseems to be unused