fix(engine): don't convert teleport op to walk/run #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful, this should fix some inconsistencies like sharks during fishing trawler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the engine converts a 1/2 tile teleport op to a walk/run, this is incorrect as the client will already convert any <= 2 teleport into a walk anyways if it's not a jump (https://github.com/2004Scape/Client/blob/67f5eda79588149043170088a53465fe3b00aa1a/client/src/main/java/client.java#L10278
This matches OSRS 1, see the p_teleport used here: https://youtu.be/FPNmOhs8jdw?si=K-5L2oh6J3OLuIjs&t=602
Previous:
chrome_JfikbnhYSs.mp4
After change:
chrome_W1XacltjVB.mp4