Skip to content

Conversation

@ipkpjersi
Copy link
Contributor

Technically this may not be necessary, and I can understand not wanting it, and I promise I won't be offended if you don't want this - but I think it's actually really good and worth having.

Here are some examples of the menu text string positioning:
Top:

Bottom:

Here are some examples of the keyboard button positioning:
Left:

Top:

Right:

@alarixnia
Copy link
Collaborator

FPS should be moved to the right in the second example to match legacy mudclients

@ipkpjersi
Copy link
Contributor Author

ipkpjersi commented May 9, 2024

It already is on the right in desktop mode fwiw, I'm not sure why it isn't in mobile mode. There might have been a specific reason for it, I've found that's usually the case for most things I've found that are different in the mobile mode.

@ipkpjersi
Copy link
Contributor Author

I've not changed the FPS display for now as we could always change that in the future if we really needed to, but I did reposition the menu text when FPS is displaying versus not.

FPS displaying:
Screenshot_2024-05-09-12-59-07-81_40deb401b9ffe8e1df2f1cc5ba480b12

FPS not displaying:
Screenshot_2024-05-09-12-59-18-66_40deb401b9ffe8e1df2f1cc5ba480b12

I think this might be good to go as is now, as long as we do want these features I added. I've tested this PR pretty heavily and it seems to work perfectly for me.

@misterhat
Copy link
Member

FPS should be moved to the right in the second example to match legacy mudclients

i think i moved it there since the UI was moved to the right, and FPS would often be obscured if a tab was open

@misterhat misterhat merged commit 087d1cb into 2003scape:master May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants