Updated Tomlyn dll with latest version (0.16.2) #34
Conversation
Updates from Unity due to new api
|
Is there any technical reason to not prefix the DLL with a hash? I did that to avoid conflicts in the past, best to keep doing it if it doesn't break the the entities package. |
| if(hasVerified) | ||
| { | ||
| try | ||
| { | ||
| verifiedVersion = SemVer.Parse(info.versions.verified); | ||
| verifiedVersion = SemVer.Parse(info.versions.recommended); |
There was a problem hiding this comment.
Breaks Unity 2021/2022.
There was a problem hiding this comment.
Added precompiled check to avoid issues with previous versions of Unity
|
I've to make some changes to maintain compatibilty with older versions of Unity that we use internally |
| @@ -11,9 +11,9 @@ | |||
| "allowUnsafeCode": false, | |||
| "overrideReferences": true, | |||
| "precompiledReferences": [ | |||
| "860BB79D.Tomlyn.dll", | |||
There was a problem hiding this comment.
No idea, but as said in the previous comment I need to make this change otherwise the Entities package will not work.
Is there a way to test if #16 is not a problem anymore?
Unfortunately this is necessary to make the Entities package work. If I don't rename it the exception cited in the linked issue will be back and you cannot use Halodi with Entities package. You can simply test it in this way:
I think this is happening because of the reply in this report Basically when there are "multiple assemblies with the same name in a project, we'll automatically pick up the highest version available in the project". So I think that because Tomlyn.dll in Entities package and the one in Halodi will have a different name, Unity tries to import both of them causing conflicts between these 2. But this is my supposition. |
|
Sounds like Unity needs to pull Tomlyn out into its own package like they did with Newtonsoft |
|
Thanks for the changes, I'll merge it. If Tomlyn still breaks, an old comment of mine would be the solution
|
Updated Tomlyn dll with latest version (0.16.2)
Updates from Unity to the file "UpgradePackagesManager.cs" due to new api