Repository navigation
[fix] preserve shared stdin buffering and EOF tails (STAR-74) - #30
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 80.54% 82.47% +1.93%
==========================================
Files 23 23
Lines 1023 1033 +10
==========================================
+ Hits 824 852 +28
+ Misses 151 139 -12
+ Partials 48 42 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successive sys.input() calls previously discarded bytes read ahead by a new temporary reader, and an EOF tail without a newline was returned as an error. Share one synchronized reader across input, stdin, and stdin_lines, preserving a final non-empty line and buffered data after an iterator stops.
Refs STAR-74. Regression tests cover repeated reads, mixed consumers, EOF, CRLF, long lines, read errors, replacement of host stdin, and real CLI pipelines.
Validation: build, race tests (count=2), vet and formatting pass. The existing CLI include capability suite still passes after rebasing on STAR-73.