Skip to content

Commit

Permalink
Fix menu bar visibility within minimized window
Browse files Browse the repository at this point in the history
  • Loading branch information
1j01 committed Jun 15, 2024
1 parent 95077a0 commit 96e03a8
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The API is unstable, and [Semantic Versioning](https://semver.org/spec/v2.0.0.ht
### Fixed

- Fixed positioning of windows when minimized without a taskbar.
- Fixed menu bar visibility when window is minimized without a taskbar. (It was typically offscreen, but you could reveal it by dragging the window.)
- Closing a window now frees up its minimize slot at the bottom of the screen (if there's no taskbar). Previously only unminimizing did this.

</details>
Expand Down
5 changes: 5 additions & 0 deletions build/layout.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/layout.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions cypress/e2e/windows.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,7 @@ describe('$Window Component', () => {
});

describe('setMenuBar', () => {
// FIXME: The menu bar is not hidden when minimized.
it.skip('should add menu bar, which is hidden when minimized', () => {
it('should add menu bar, which is hidden when minimized', () => {
cy.window().then((win) => {
const $window = win.$Window({
title: 'Test Window',
Expand Down
5 changes: 5 additions & 0 deletions src/layout.css
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ body > .window-titlebar {
display: none; /* prevent resizing when window is minimized */
}

.os-window.minimized-without-taskbar .menus {
display: none; /* hide menubar when window is minimized */
}


/* Fix dragging things (like windows) over iframes */
.dragging iframe {
pointer-events: none;
Expand Down

0 comments on commit 96e03a8

Please sign in to comment.