Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated THRESHOLD description #295

Merged
merged 3 commits into from
Dec 13, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated THRESHOLD description
  • Loading branch information
byshape committed Dec 8, 2023
commit 9cd4bed832120bec4cabdca4c7fe7c070b0734cc
2 changes: 1 addition & 1 deletion description.md
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ The `takerTraits` argument provides a number of options for the taker to choose
| ARGS_HAS_TARGET | 251 bit | 1 | If set, then first 20 bytes of args are treated as target address for maker’s funds transfer |
| ARGS_EXTENSION_LENGTH | 224-247 | 24 | Extension calldata coded in args argument length |
| ARGS_INTERACTION_LENGTH | 200-223 | 24 | Taker’s interaction calldata coded in args argument length |
| THRESHOLD | 0-184 | 184 | The maximum amount a taker agrees to give in exchange for a making amount. If the calculated taker amount is less than the threshold, then the transaction will be reverted. A zero (0) threshold skips the check. The evaluated equation is<br/>$$ threshold amount*{takingAmount \over makingAmount} $$ |
| THRESHOLD | 0-184 | 184 | Depending on the MAKER_AMOUNT_FLAG, this can be the maximum amount the taker agrees to give in exchange for the making amount (flag is 1) or the minimum amount the taker agrees to receive (flag is 0). If the calculated taker amount is outside the threshold, then the transaction will be reverted. A zero (0) threshold skips the check. The evaluated equation for flag = 1 is<br/>$$ threshold amount*{takingAmount \over makingAmount} $$<br>For flag = 0 is $$ threshold ≤ amount*{makingAmount \over takingAmount } $$ |
byshape marked this conversation as resolved.
Show resolved Hide resolved

# Cancelling an order

Expand Down
Loading