Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to not displaying the fake light around mercs #86

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

majcosta
Copy link
Contributor

Looks nicer, mercs don't normally glow.

Also remove the legacy "frame saving" Merc Lights during movement option since that has not been a problem for any computer/mobile phone built in the past 15 years.

This might've cost someone some frames in 1999, but today even a 10
year old smartphone can probably run with this turned on at 1080p without
dropping a sweat

This does not remove the menu option which I plan to replace with
'Highlight Mercs' which was hidden for some reason.

'Merc Lights during Movement' is a noop now tho
"Wtf why am I glowing?" well your problems are over
@majcosta
Copy link
Contributor Author

Dear Merger, if possible please Squash thanks

@Asdow Asdow merged commit 6afe785 into 1dot13:master Jan 18, 2023
@majcosta majcosta deleted the pr_default_merc_cast_light_off branch January 22, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants