Доработки 240705 #463
Merged
Доработки 240705 #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughНедавние изменения касаются нескольких модулей проекта, включая новые поля, методы и тесты, а также упорядочивание элементов в файлах конфигурации. Эти обновления направлены на улучшение функциональности и обеспечение более точного контроля за последовательностью обработки данных и конфигурационных расширений. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (42)
src/test/resources/ext/designer/mdclasses/src/cf/FilterCriteria/КритерийОтбора1.xmlis excluded by!**/*.xmlsrc/test/resources/ext/designer/mdclasses/src/cf/Sequences/Последовательность1.xmlis excluded by!**/*.xmlsrc/test/resources/ext/designer/mdclasses_ext/src/cf/Configuration.xmlis excluded by!**/*.xmlsrc/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Catalogs.Справочник1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Catalogs.Справочник1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Configuration.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Configuration_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Constants.Константа1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Constants.Константа1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Documents.Документ1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Documents.Документ1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/ExternalDataSources.ТекущаяСУБД.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/ExternalDataSources.ТекущаяСУБД_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/FilterCriteria.КритерийОтбора1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/FilterCriteria.КритерийОтбора1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Reports.Отчет1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Reports.Отчет1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Sequences.Последовательность1.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses/Sequences.Последовательность1_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses_3_24/Configuration_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses_ext/Configuration.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/mdclasses_ext/Configuration_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Catalogs.Заметки.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Catalogs.Заметки_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/DataProcessors.ЗагрузкаКурсовВалют.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/DataProcessors.ЗагрузкаКурсовВалют_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Documents.Анкета.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Documents.Анкета_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/FilterCriteria.ФайлыВТоме.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/FilterCriteria.ФайлыВТоме_edt.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя.jsonis excluded by!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя_edt.jsonis excluded by!**/*.json
Files selected for processing (8)
- src/main/java/com/github/_1c_syntax/bsl/mdo/BusinessProcess.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/FilterCriterion.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Sequence.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/reader/common/context/MDCReaderContext.java (2 hunks)
- src/test/java/com/github/_1c_syntax/bsl/mdclasses/ConfigurationTest.java (5 hunks)
- src/test/resources/ext/edt/mdclasses/configuration/src/FilterCriteria/КритерийОтбора1/КритерийОтбора1.mdo (1 hunks)
- src/test/resources/ext/edt/mdclasses/configuration/src/Sequences/Последовательность1/Последовательность1.mdo (1 hunks)
- src/test/resources/ext/edt/mdclasses_ext/configuration/src/Configuration/Configuration.mdo (1 hunks)
Files skipped from review due to trivial changes (1)
- src/test/resources/ext/edt/mdclasses_ext/configuration/src/Configuration/Configuration.mdo
Additional comments not posted (9)
src/test/resources/ext/edt/mdclasses/configuration/src/FilterCriteria/КритерийОтбора1/КритерийОтбора1.mdo (2)
10-10: Добавлен элемент контента.Элемент контента
Document.Документ1.Attribute.Реквизит1добавлен корректно.
11-11: Добавлен элемент контента.Элемент контента
Document.Документ1.Attribute.Реквизит2добавлен корректно.src/test/resources/ext/edt/mdclasses/configuration/src/Sequences/Последовательность1/Последовательность1.mdo (1)
10-10: Добавлен элемент документа.Элемент документа
Document.Документ2добавлен корректно.src/main/java/com/github/_1c_syntax/bsl/mdo/Sequence.java (2)
75-77: Добавлен комментарий документации для поляdimensions.Комментарий документации добавлен корректно и предоставляет полезную информацию.
81-85: Добавлен комментарий документации и аннотация для поляdocuments.Комментарий документации и аннотация
@Singular("addDocuments")добавлены корректно и предоставляют полезную информацию.src/main/java/com/github/_1c_syntax/bsl/mdo/FilterCriterion.java (1)
95-99: Добавлен комментарий документации и аннотация для поляcontent.Комментарий документации и аннотация
@Singular("addContent")добавлены корректно и предоставляют полезную информацию.src/main/java/com/github/_1c_syntax/bsl/mdo/BusinessProcess.java (1)
102-106: Изменение одобрено.Поле
taskдобавлено корректно с соответствующими аннотациями и значением по умолчанию.src/main/java/com/github/_1c_syntax/bsl/reader/common/context/MDCReaderContext.java (1)
118-128: Изменение одобрено.Использование
collect(Collectors.toMap(...))вместоtoList()гарантирует сохранение порядка дочерних элементов на основеchildrenNames. Это важное исправление для поддержания порядка объектов конфигурации.src/test/java/com/github/_1c_syntax/bsl/mdclasses/ConfigurationTest.java (1)
249-262: Изменение одобрено.Новые методы
testFullExtEdtиcheckChildrenOrderдобавлены корректно и соответствуют существующей структуре и стилю тестового класса.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes: #252
Closes: #259
Closes: #256
Closes: #221
Чеклист
Общие
gradlew precommit)Дополнительно