Skip to content

Remove node_modules folder and add it to .gitignore #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

walker84837
Copy link

I'm really not a JavaScript expert, but I'd be pretty sure that node_modules includes all dependencies.

@1arp
Copy link
Owner

1arp commented Jul 5, 2025

Hi,
You are right that we shouldn't be committing in the node_modules folder but the way github actions work (downloading the project and running the script) we have to include the required dependencies.
That was the recommended way when I wrote this action. Now they recommend to bundle the required dependencies into a single file using bundlers.
If you create a PR for the bundler, preferably swc, I'd be happy to take a look at it.

@1arp 1arp closed this Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants