feat: optionally disable wasmbind #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanaye
approved these changes
Aug 26, 2024
|
Hi @8e8b2c, this repo requires all commits to be signed. You will need to setup commit signing and rebase your changes. Thanks for your contribution! |
8e8b2c
force-pushed
the
opt-disable-wasmbind
branch
from
ccb29d3
to
3e5259c
Compare
Done :) |
|
@seanaye any chance this one can get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue:
#191
Make the
chrono/wasmbindfeature optional viadefault-features = falsein order to prevent unwanted wasm module exports in environments where interfaces are restricted.