Terraform shouldn't error when we cannot find a secret by ID, as we may need to recreate a manually deleted secret

[josh-thisisbud]

terraform-provider-onepassword/internal/provider/onepassword_item_resource.go

Line 372 in c6e0ebd

resp.Diagnostics.AddError("1Password Item read error", fmt.Sprintf("Could not get item '%s' from vault '%s', got error: %s", itemUUID, vaultUUID, err))

This line here shouldn't be bombing out during a terraform run, as it's entirely valid that the secret may have been deleted and we need to recreate it. I'd suggest turning this into a warning at most, so that people can learn that it happened from logging?

[garbelini]

Agreed. Providers should not error on 404s.

Seems like the code delegates the call to the cli that fails when an item is not found. That's appropriate for a cli but not for a terraform provider.