Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hemal/modify recommended resources #118

Merged
merged 13 commits into from
Feb 24, 2023
Merged

Conversation

Hemal1P
Copy link
Contributor

@Hemal1P Hemal1P commented Feb 22, 2023

Overview

To improve upon high volume deployments whose SCIM bridge crashes due to low resources we are increasing
recommendations.

Changes

  • Readme.md has been updated with recommended resources for various deployments.

Checklist

@Hemal1P Hemal1P requested a review from chasdl February 22, 2023 17:45
@chasdl
Copy link
Collaborator

chasdl commented Feb 22, 2023

Thanks Hemal! I'm thinking we can modify the table values. 2000 is a bit low for the high volume deployment, let's adjust the range a bit to 5000. Let's do:

| 100 - 5000 | High Volume Deployment |
| 5000+ | Very High Volume Deployment |

alicethorne-ab
alicethorne-ab previously approved these changes Feb 23, 2023
Copy link
Contributor

@alicethorne-ab alicethorne-ab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but otherwise, this LGTM. :shipit:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
chasdl
chasdl previously approved these changes Feb 24, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Chas Lynch <chas.lynch@agilebits.com>
@Hemal1P Hemal1P merged commit d097cc7 into main Feb 24, 2023
@Hemal1P Hemal1P deleted the hemal/modify-recommended-resources branch February 24, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants