Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable using loaded secrets from step's output #7

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Enable using loaded secrets from step's output #7

merged 3 commits into from
Sep 2, 2021

Conversation

edif2008
Copy link
Member

@edif2008 edif2008 commented Sep 1, 2021

The following significant changes are present in this PR:

  • switch the action type to node from composite to allow dynamic ouput from the action
  • enable the user to load secrets in 2 ways: from output, or from exported environment variables; this is set by the input export-env

@edif2008
Switch to node action
ac12d2e 
This is done to be able to pass loaded secrets as output. This is not available with a composite action, unless we hard-code the action's outputs, which is not a desired outcome.
@edif2008
Enable using loaded secrets from step's output
4baca64
@edif2008 edif2008 merged commit fae9e58 into feature/add-cli Sep 2, 2021
@edif2008 edif2008 deleted the feature/output-secrets branch September 2, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillianwilson jillianwilson jillianwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edif2008 @jillianwilson