-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds possibility to set image pull secrets in all charts #204
feat: Adds possibility to set image pull secrets in all charts #204
Conversation
Also fixed some whitespace issues in the two templates I touched. |
@edif2008 Fixed the linting errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution and adding this enhancement! 😊
I've left a couple of small comments and once they're addressed, I will approve this PR.
I've also noticed just now that your branch seems to be in conflict with the latest |
bd87082
to
1da8285
Compare
@edif2008 thx for your review, fixed all your comments :) |
Hi @luflow 👋. I merged another one PR #170 earlier today, which caused the conflicts with your one 🤦♂️. I solved them, but looks like there is a protection rule on your forked repo, so I could not push the changes into your branch. I'd appreciate if you have a chance resolve the conflicts once again. Or give us permission to push to your branch, so we can help you with that. And finally merge you PR 😃 Sorry for the inconvenience. I appreciate the efforts and the time you put into making this contribution! 👍 |
@edif2008 @volodymyrZotov Done :) |
@edif2008 @volodymyrZotov anything else needed? :) Looking forward to the merge 🤩 |
Adds possibility of image pull secrets to all charts
on connect: global
on secrets injector: in the injector scope
closes #203