Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commits URL from PR event data #4

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

florisvdg
Copy link
Member

@florisvdg florisvdg commented Jul 14, 2023

Instead of determining the PR commits URL in the code, use the PR event data provided by GitHub.

This should add support for commenting on fork PRs using pull_request_target.

@florisvdg
Copy link
Member Author

Tested here on a fork, the forked PR now shows the comment.

@SimonBarendse SimonBarendse merged commit 8b94ee1 into main Sep 22, 2023
1 check passed
@SimonBarendse SimonBarendse deleted the pull-request-target-support branch September 22, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants