fix: Chat log search #3943
fix: Chat log search #3943
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -101,7 +101,7 @@ def get_query_set(self, select_ids=None): | |||
| if 'abstract' in self.data and self.data.get('abstract') is not None: | |||
| base_query_dict['application_chat.abstract__icontains'] = self.data.get('abstract') | |||
| if 'username' in self.data and self.data.get('username') is not None: | |||
| base_query_dict['application_chat.asker__username'] = self.data.get('username') | |||
| base_query_dict['application_chat.asker__username__icontains'] = self.data.get('username') | |||
|
|
|||
|
|
|||
| if select_ids is not None and len(select_ids) > 0: | |||
There was a problem hiding this comment.
No, there are no irregularities or potential issues with the code provided. The only change to note is that asker__username should be converted to asker__username__icontains. This ensures that all usernames starting with the given username query will match when using an ICONTAINS lookup, which allows partial text matches.
The changes:
# Old line (without iexact)
- base_query_dict['application_chat.asker__username'] = self.data.get('username')
# New line with iexact
+ base_query_dict['application_chat.asker__username__icontains'] = self.data.get('username')This makes sure the filter works as expected for both exact and partial matches of the username field.
fix: Chat log search