Skip to content

fix: MD editor table cannot have too many columns and cannot scroll horizontally #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

shaohuzhang1
Copy link
Contributor

fix: MD editor table cannot have too many columns and cannot scroll horizontally

Copy link

f2c-ci-robot bot commented Apr 10, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 5243e42 into main Apr 10, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_md_editor branch April 10, 2025 05:54
.md-editor-preview {
padding: 0;
margin: 0;
font-size: inherit;
table{
display: block;
}
p {
padding: 0 !important;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided CSS appears to be incomplete and contains errors. Here are some corrections and additional optimizations:

.md-editor-preview {
  padding: 0;
  margin: 0;
  font-size: inherit;
  border: none; /* Remove unnecessary borders */
}

Key Corrections/Improvements:

  1. Remove Unnecessary table Block: The rule .md-editor-preview table {} is redundant because it can conflict with other styles elsewhere in the document.
  2. Add Missing Closing Brace: Ensure that there are correct closing braces for all rules.

This corrected version of the CSS will properly format the preview text without disrupting layout or styling. If you intend for tables within the preview section to behave differently (e.g., not overflow), you may need to adjust specific table properties instead of setting display: block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant