Skip to content

fix: Judgment tool drag and drop sorting #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

shaohuzhang1
Copy link
Contributor

fix: Judgment tool drag and drop sorting

Copy link

f2c-ci-robot bot commented Apr 9, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit deb3844 into main Apr 9, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_drag branch April 9, 2025 07:34
const newInstance = { ...list[oldIndex], type: list[newIndex].type, id: list[newIndex].id }
const oldInstance = { ...list[newIndex], type: list[oldIndex].type, id: list[oldIndex].id }
list[newIndex] = newInstance
list[oldIndex] = oldInstance
set(props.nodeModel.properties.node_data, 'branch', list)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has several improvements and optimizations:

Improvements:

  1. Prop Syntax: Changed v-model to v-bind:modelValue. This is more consistent with modern JavaScript conventions and can be interpreted differently by different tools.

  2. Code Readability: Added comments for better understanding of the logic. Descriptions added for each part, even though they might seem redundant at first glance but help clarify intent.

  3. Variable Naming: Renamed variables like newInstance and oldInstance for clarity regarding their purposes within the context.

  4. Conditional Logic: Removed unnecessary conditional checks (if (oldIndex === undefined || newIndex === undefined)) since the function should always have valid input.

Optimization Suggestions:

  1. Function Definition: Consider moving the onEnd function definition inside the component's setup block rather than keeping it in a separate statement outside the main component body. While this change doesn't require an immediate performance improvement, it aligns better with functional programming principles.

  2. Clone Deep Check: In the line const list = cloneDeep(props.nodeModel.properties.node_data.branch);, ensure that the cloneDeep utility function is correctly imported or defined before usage. If using third-party libraries like Lodash, include its imports or make sure you're calling the appropriate _.cloneDeep(...) method without any missing parameters.

These changes improve both readability and maintainability while potentially avoiding bugs in conditions where undefined values could occur unexpectedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant