Skip to content

feat: New condition for determining whether the discriminator is true or not #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

feat: New condition for determining whether the discriminator is true or not #2809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2212e9
feat: New condition for determining whether the discriminator is true…
shaohuzhang1 Apr 7, 2025
1764a72
feat: New condition for determining whether the discriminator is true…
shaohuzhang1 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions apps/application/flow/step_node/condition_node/compare/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,22 @@

from .contain_compare import *
from .equal_compare import *
from .gt_compare import *
from .ge_compare import *
from .gt_compare import *
from .is_not_null_compare import *
from .is_not_true import IsNotTrueCompare
from .is_null_compare import *
from .is_true import IsTrueCompare
from .le_compare import *
from .lt_compare import *
from .len_equal_compare import *
from .len_ge_compare import *
from .len_gt_compare import *
from .len_le_compare import *
from .len_lt_compare import *
from .len_equal_compare import *
from .is_not_null_compare import *
from .is_null_compare import *
from .lt_compare import *
from .not_contain_compare import *

compare_handle_list = [GECompare(), GTCompare(), ContainCompare(), EqualCompare(), LTCompare(), LECompare(),
LenLECompare(), LenGECompare(), LenEqualCompare(), LenGTCompare(), LenLTCompare(),
IsNullCompare(),
IsNotNullCompare(), NotContainCompare()]
IsNotNullCompare(), NotContainCompare(), IsTrueCompare(), IsNotTrueCompare()]
24 changes: 24 additions & 0 deletions apps/application/flow/step_node/condition_node/compare/is_not_true.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# coding=utf-8
"""
@project: MaxKB
@Author：虎
@file： is_not_true.py
@date：2025/4/7 13:44
@desc:
"""
from typing import List

from application.flow.step_node.condition_node.compare import Compare


class IsNotTrueCompare(Compare):

def support(self, node_id, fields: List[str], source_value, compare, target_value):
if compare == 'is_not_ture':
return True

def compare(self, source_value, compare, target_value):
try:
return source_value is False
except Exception as e:
return False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided Python code has several issues that need to be addressed:

  1. Syntax Error: The line @@ -0,0 +1,24 @@ seems to be an SVN diff command and should not appear at the start of a file when you're checking the syntax.

  2. Python Version Compatibility: Using Unicode-specific encoding (# coding=utf-8) might cause compatibility issues with older versions of Python (e.g., Python 2), but it's generally safe in modern Python environments since many newer codecs like UTF-8 are supported across different platforms.

  3. Docstring: There is no consistent documentation style between comments and docstrings. This can make the code harder to understand and maintain.

  4. Class Name and Method Names: Class names should follow PEP 8 standards, which recommend snake_case instead of CamelCase. Similarly, method names should also use camelCase.

  5. Import Statements: Import statements should be placed after class definitions or function declarations, according to best practices for modularity.

  6. Exception Handling: While catching exceptions helps in error handling, they come with a cost. It’s better to handle specific exceptions that may occur without affecting other parts of the program. In this case, a ValueError could provide more context about what went wrong with the source value.

  7. Logic Check: The logic for determining if something is "not true" isn't clear from the implementation. It currently checks if source_value is equal to False, but there might have been intended to compare against another value. Assuming the intent was to return whether the source_value evaluates to a boolean false, the method signature needs to match and the comparison should be done accordingly.

Here's a revised version of the code addressing these issues:

import functools

from application.flow.step_node.condition_node.compare import Compare


@functools.lru_cache(None)
class IsNotTrueCompare(Compare):

    def support(self, node_id, fields=None, source_value=None, compare='is_not_true', target_value=None):
        if compare.lower() == 'is_not_true':
            return True
        
        try:
            return bool(source_value) is False
        except TypeError:
            # If source_value cannot be converted to boolean, consider it as False
            return False

Changes Made:

  • Removed the unnecessary SVN diff marker.
  • Changed class name to IsNotTrueCompare.
  • Fixed incorrect comment format within the class definition.
  • Corrected method names and parameters.
  • Added import statement for functools.lru_cache for memory efficiency.
  • Improved exception handling by specifically catching TypeError.
  • Adjusted the logic to correctly evaluate if a value represents falsiness.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code有几个潜在的问题和技术优化建议：

  1. Docstring Issues: The docstrings need to be expanded for clarity, especially around the support and compare methods.

  2. Type Annotations: The use of type annotations for generic list types can add readability and type safety. However, they might not impact performance significantly in this context without using them excessively.

  3. Variable Naming: Using underscores for private variables is a good convention but unnecessary here since all class members are being used directly in public methods. You only need underscores for special names like _protected, _private.

  4. Exception Handling: In the compare method, the specific exception (ValueError) should be caught more specifically or removed entirely depending on whether it makes sense for your codebase (e.g., if you want to handle other exceptions).

  5. Functionality Clarity: The name IsNotTrueCompare suggests functionality that's different from simply checking if something "is true". Consider renaming to make its purpose clearer (e.g., IsNotFalse). Also, the logic inside the support method seems redundant; just returning immediately when comparing against 'is_not_true' would suffice.

  6. Code Formatting and Readability: Ensure consistent indentation, spacing, and comment style throughout the code block for better readability. It also helps with maintaining code integrity.

Here’s an enhanced version with these considerations:

# coding=utf-8
"""
    @project: MaxKB
    @Author：虎
    @file： is_not_true.py
    @date：2025/4/7 13:44
    @desc: Custom compare condition based on 'is not true'.
"""

from typing import List

from application.flow.step_node.condition_node.compare import Compare


class IsNotTrueCompare(Compare):

    def support(self, node_id: str, fields: List[str], source_value, compare_type: str, target_value: any) -> bool:
        """
        Determines if 'source_value' does not equal 'target_value'.

        Args:
            self: Instance of IsNotTrueCompare.
            node_id (str): Identifier of the current node.
            fields: List of field names associated with the condition.
            source_value: Value to evaluate as truthiness.
            compare_type: Type of comparison ('is_not_true').
            target_value: Target value to compare against.

        Returns:
            bool: True if 'source_value' evaluates to false, False otherwise.
        """
        if isinstance(source_value, bool):
            return not source_value
        
        supported_comparisons = {'is_not_true': True}
        
        # Check if the given comparison type supports logical inversion
        if compare_type in supported_comparisons:
            return not source_value
            
        raise ValueError(f"Unsupported comparison type '{compare_type}'")

    def compare(
        self,
        source_value: bool,
        compare_type: str,
        target_value: any
    ) -> bool:
        """
        Performs the actual comparison logic.

        Args:
            source_value (bool): Boolean value to evaluate as truthiness.
            compare_type: Comparison type (ignored since we invert boolean values).
            target_value: Target value (unused since we invert boolean values).

        Returns:
            bool: Logical inverse result of evaluating boolean value 'source_value'.
        """

        if not isinstance(source_value, bool):
            # Fallback to standard non-null evaluation
            return bool(source_value)
            
        return not source_value  # Simple inverted boolean logic

This enhanced version provides a more structured approach to handling boolean comparison logic with clear documentation and improved error checking.

24 changes: 24 additions & 0 deletions apps/application/flow/step_node/condition_node/compare/is_true.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# coding=utf-8
"""
@project: MaxKB
@Author：虎
@file： IsTrue.py
@date：2025/4/7 13:38
@desc:
"""
from typing import List

from application.flow.step_node.condition_node.compare import Compare


class IsTrueCompare(Compare):

def support(self, node_id, fields: List[str], source_value, compare, target_value):
if compare == 'is_ture':
return True

def compare(self, source_value, compare, target_value):
try:
return source_value is True
except Exception as e:
return False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has several issues that need to be addressed:

  1. Missing Type Annotations: The fields parameter should have type annotations since it's a list of strings.

  2. Incorrect Method Overriding Signature:

    • The support method is expected take three parameters (node_id, fields, and source_value) and return a boolean value.
    • The compare method is defined but does not accept the required compare and target_value arguments (it accepts only source_value).
    • It's unclear how these methods fit together in an abstract base class like Compare.

  3. Potential Issues and Improvements:

    • The use of exception handling for checking type compatibility could lead to unexpected behaviors; prefer safer alternatives or additional checks.
    • Consider renaming methods or adding descriptive comments to clarify their purpose and functionality.

Here’s an improved version of the code with some recommendations:

# coding=utf-8
"""
    @project: MaxKB
    @Author：虎
    @file： IsTrue.py
    @date：2025/4/7 13:38
    @desc:
"""

from typing import List

from application.flow.step_node.condition_node.compare import Compare


class IsTrueCompare(Compare):

    def support(self, node_id:str, fields:List[str], source_value, compare_type) -> bool:
        # Ensure compare_type is one of the allowed values
        supported_types = ['is_true', 'is_false']
        if compare_type.lower() not in supported_types:
            raise ValueError(f"Unsupported comparison type '{compare_type}'. Supported types are {supported_types}")
        
        # Return True if the comparison type matches the input
        return compare_type.lower() == 'is_true'

    def compare(self, source_value, compare_type, target=None):
        """
        Compares a source value against a specified condition using the given comparison type.
        :param source_value: The value to be compared.
        :param compare_type: A string specifying the type of comparison ('is_true' or 'is_false').
        :param target: Ignored.
        :return: True if the comparison applies to source_value based on compare_type, otherwise False.
        """
        if source_value is None or not isinstance(source_value, bool):
            return False
        
        # Perform specific comparisons based on compare_type
        if compare_type.upper() == 'IS_TRUE':
            return source_value
        elif compare_type.upper() == 'IS_FALSE':
            return not source_value

Changes Made:

  1. Type Annotations: Added type hints to fields and other parameters where necessary.
  2. Overloaded Methods: Corrected the signature of both the support and compare methods to match their expected inputs.
  3. Improved Error Handling: Added error handling to ensure compare_type is valid.
  4. Clarified Logic: Improved clarity by using meaningful function names and comments explaining logic steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly correct for its intended purpose of checking if a value "is true" based on the compare argument. However, here are some suggestions:

  1. Code Organization: The class name and method names could be improved to follow Python naming conventions.
  2. Type Annotations: Ensure all type hints and expected data types align with Python's built-in types.
  3. Error Handling: Consider logging exceptions instead of simply returning False.
  4. Comments: Add documentation comments to clarify the methods' behavior.

Here's an optimized version of the code with these improvements:

# -*- coding: utf-8 -*-
"""
@project: MaxKB
@author：虎
@file：IsTrue.py
@date：2025/4/7 13:38
@desc:
"""

from typing import List

from application.flow.step_node.condition_node.compare import BaseConditionNode


class IsTrueCompare(BaseConditionNode):

    def support(self, node_id, fields: List[str], source_value, compare_strategy, target_value) -> bool:
        """
        Check if the source value meets an 'is_true' condition against the target value.

        Args:
            node_id (str): Node identifier.
            fields (List[str]): Not used in this implementation.
            source_value: Value to be compared.
            compare_strategy (str): Determines how comparison is performed ('is_true', etc.
            target_value: Not used in this specific implementation.

        Returns:
            bool: True if the condition is met, False otherwise.
        """
        return compare_strategy.lower() == 'is_true'

    def compare(self, source_value, condition, target_value=None) -> bool:
        """
        Compare the source value against the target using the specified condition.

        Since 'is_true' requires direct truthiness, the target should not be provided.

        Args:
            source_value: Boolean value to be checked.
            condition (any): Comparison logic to evaluate. In this case, it should be a string.
            target_value: Not used in this specific implementation.

        Raises:
            ValueError: If the condition is not 'is_true'.

        Returns:
            bool: True if the condition evaluates to True, False otherwise.
        """
        if condition != 'is_true':
            raise ValueError(f"Unsupported comparison strategy '{condition}'. Use 'is_true'.")
        
        return bool(source_value)

Key Changes:

  1. Class Name: Replaced .IsTrueCompare with BaseConditionNode and made it inherit from BaseConditionNode, which ensures compatibility with other conditions.
  2. Method Names: Changed method names to fit Python convention (support to supports).
  3. Return Type Hints: Updated function signatures to use appropriate return types.
  4. Error Handling: Improved error handling.
  5. Documentation: Added docstrings for clarity.

6 changes: 5 additions & 1 deletion apps/application/flow/step_node/condition_node/impl/base_condition_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ def assertion(self, field_list: List[str], compare: str, value):
value = self.workflow_manage.generate_prompt(value)
except Exception as e:
pass
field_value = self.workflow_manage.get_reference_field(field_list[0], field_list[1:])
field_value = None
try:
field_value = self.workflow_manage.get_reference_field(field_list[0], field_list[1:])
except Exception as e:
pass
for compare_handler in compare_handle_list:
if compare_handler.support(field_list[0], field_list[1:], field_value, compare, value):
return compare_handler.compare(field_value, compare, value)
Expand Down
10 changes: 6 additions & 4 deletions ui/src/locales/lang/en-US/views/application-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default {
copyParam: 'Copy Parameters',
debug: 'Run',
exit: 'Exit',
exitSave: 'Save & Exit',
exitSave: 'Save & Exit'
},
tip: {
publicSuccess: 'Published successfully',
Expand All @@ -37,7 +37,7 @@ export default {
cannotCopy: 'Cannot be copied',
copyError: 'Node already copied',
paramErrorMessage: 'Parameter already exists: ',
saveMessage: 'Current changes have not been saved. Save before exiting?',
saveMessage: 'Current changes have not been saved. Save before exiting?'
},
delete: {
confirmTitle: 'Confirm to delete this node?',
Expand Down Expand Up @@ -229,7 +229,7 @@ export default {
toolParam: 'Tool Params',
mcpServerTip: 'Please enter the JSON format of the MCP server config',
mcpToolTip: 'Please select a tool',
configLabel: 'MCP Server Config (Only supports SSE call method)',
configLabel: 'MCP Server Config (Only supports SSE call method)'
},
imageGenerateNode: {
label: 'Image Generation',
Expand Down Expand Up @@ -293,7 +293,9 @@ export default {
len_ge: 'Length greater than or equal to',
len_gt: 'Length greater than',
len_le: 'Length less than or equal to',
len_lt: 'Length less than'
len_lt: 'Length less than',
is_true: 'Is true',
is_not_true: 'Is not true'
},
FileUploadSetting: {}
}
8 changes: 5 additions & 3 deletions ui/src/locales/lang/zh-CN/views/application-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default {
copyParam: '复制参数',
debug: '调试',
exit: '直接退出',
exitSave: '保存并退出',
exitSave: '保存并退出'
},
tip: {
publicSuccess: '发布成功',
Expand All @@ -37,7 +37,7 @@ export default {
cannotCopy: '不能被复制',
copyError: '已复制节点',
paramErrorMessage: '参数已存在: ',
saveMessage: '当前的更改尚未保存，是否保存后退出?',
saveMessage: '当前的更改尚未保存，是否保存后退出?'
},
delete: {
confirmTitle: '确定删除该节点？',
Expand Down Expand Up @@ -292,7 +292,9 @@ export default {
len_ge: '长度大于等于',
len_gt: '长度大于',
len_le: '长度小于等于',
len_lt: '长度小于'
len_lt: '长度小于',
is_true: '为真',
is_not_true: '不为真'
},
FileUploadSetting: {}
}
10 changes: 6 additions & 4 deletions ui/src/locales/lang/zh-Hant/views/application-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default {
copyParam: '複製參數',
debug: '調試',
exit: '直接退出',
exitSave: '保存並退出',
exitSave: '保存並退出'
},
tip: {
publicSuccess: '發布成功',
Expand All @@ -37,7 +37,7 @@ export default {
cannotCopy: '不能被複製',
copyError: '已複製節點',
paramErrorMessage: '參數已存在: ',
saveMessage: '當前修改未保存，是否保存後退出？',
saveMessage: '當前修改未保存，是否保存後退出？'
},
delete: {
confirmTitle: '確定刪除該節點？',
Expand Down Expand Up @@ -229,7 +229,7 @@ export default {
toolParam: '工具變數',
mcpServerTip: '請輸入JSON格式的MCP服務器配置',
mcpToolTip: '請選擇工具',
configLabel: 'MCP Server Config (僅支持SSE調用方式)',
configLabel: 'MCP Server Config (僅支持SSE調用方式)'
},
imageGenerateNode: {
label: '圖片生成',
Expand Down Expand Up @@ -292,7 +292,9 @@ export default {
len_ge: '長度大於等於',
len_gt: '長度大於',
len_le: '長度小於等於',
len_lt: '長度小於'
len_lt: '長度小於',
is_true: '為真',
is_not_true: '不為真'
},
FileUploadSetting: {}
}
8 changes: 5 additions & 3 deletions ui/src/workflow/common/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export const mcpNode = {
properties: {
stepName: t('views.applicationWorkflow.nodes.mcpNode.label'),
config: {
fields:[
fields: [
{
label: t('common.result'),
value: 'result'
Expand Down Expand Up @@ -424,7 +424,9 @@ export const compareList = [
{ value: 'len_ge', label: t('views.applicationWorkflow.compare.len_ge') },
{ value: 'len_gt', label: t('views.applicationWorkflow.compare.len_gt') },
{ value: 'len_le', label: t('views.applicationWorkflow.compare.len_le') },
{ value: 'len_lt', label: t('views.applicationWorkflow.compare.len_lt') }
{ value: 'len_lt', label: t('views.applicationWorkflow.compare.len_lt') },
{ value: 'is_true', label: t('views.applicationWorkflow.compare.is_true') },
{ value: 'is_not_true', label: t('views.applicationWorkflow.compare.is_not_true') }
]

export const nodeDict: any = {
Expand All @@ -446,7 +448,7 @@ export const nodeDict: any = {
[WorkflowType.SpeechToTextNode]: speechToTextNode,
[WorkflowType.ImageGenerateNode]: imageGenerateNode,
[WorkflowType.VariableAssignNode]: variableAssignNode,
[WorkflowType.McpNode]: mcpNode,
[WorkflowType.McpNode]: mcpNode
}
export function isWorkFlow(type: string | undefined) {
return type === 'WORK_FLOW'
Expand Down
23 changes: 10 additions & 13 deletions ui/src/workflow/nodes/condition-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,8 @@
size="small"
style="width: 60px; margin: 0 8px"
>
<el-option
:label="$t('views.applicationWorkflow.condition.AND')"
value="and"
/>
<el-option
:label="$t('views.applicationWorkflow.condition.OR')"
value="or"
/>
<el-option :label="$t('views.applicationWorkflow.condition.AND')" value="and" />
<el-option :label="$t('views.applicationWorkflow.condition.OR')" value="or" />
</el-select>
<span>{{
$t('views.applicationWorkflow.nodes.conditionNode.conditions.label')
Expand All @@ -56,9 +50,7 @@
ref="nodeCascaderRef"
:nodeModel="nodeModel"
class="w-full"
:placeholder="
$t('views.applicationWorkflow.variable.placeholder')
"
:placeholder="$t('views.applicationWorkflow.variable.placeholder')"
v-model="condition.field"
/>
</el-form-item>
Expand Down Expand Up @@ -94,7 +86,11 @@
</el-col>
<el-col :span="6">
<el-form-item
v-if="condition.compare !== 'is_null' && condition.compare !== 'is_not_null'"
v-if="
!['is_null', 'is_not_null', 'is_true', 'is_not_true'].includes(
condition.compare
)
"
:prop="'branch.' + index + '.conditions.' + cIndex + '.value'"
:rules="{
required: true,
Expand Down Expand Up @@ -137,7 +133,8 @@
</el-card>
</template>
<el-button link type="primary" @click="addBranch">
<el-icon class="mr-4"><Plus /></el-icon> {{ $t('views.applicationWorkflow.nodes.conditionNode.addBranch') }}
<el-icon class="mr-4"><Plus /></el-icon>
{{ $t('views.applicationWorkflow.nodes.conditionNode.addBranch') }}
</el-button>
</el-form>
</NodeContainer>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly clean overall, with only minor cosmetic issues to be addressed. Here are the suggestions:

  1. Remove Duplicate el-select Options:
    The second and third <el-option> rows have identical content, which is unnecessary. Only keep one and remove the duplicate.

  2. Simplify Logic for Conditional Visibility:
    For the visibility of input fields based on condition.compare, consider using a computed property or method instead of inline logic. This makes the template cleaner and easier to update if needed.

  3. Remove Duplicates in Logical Conditions:
    In the conditional statement that determines whether a field should be excluded from selection, include "is_null" as well, since it's already accounted for in 'is_true' and 'is_not_null'.

  4. Minor Typographical Fixes:
    Ensure there are no lingering typographical errors (e.g., spaces before semicolons) though they are minimal.

Here's a suggested version of the updated code:

<template>
  <!-- Existing template structure -->
  <!-- ... -->

  <!-- Button block remains unchanged -->
</template>

<script setup lang="ts">
// Import necessary dependencies at the top

const addBranch = () => {};
</script>

These changes focus primarily on simplification and clarity without significant impact on functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no significant irregularities or potential issues detected in the provided code snippet. However, here is a few optimization suggestions:

  1. Duplicate Options Handling: The <el-option> elements for AND and OR conditions appear twice with identical labels and values. You can simplify this by including them only once.

  2. Placeholders: It might be beneficial to store common placeholders like "variable placeholder" in this.$t at the beginning of your script instead of repeating it multiple times.

Here's an optimized version of your code:

<template>
  <!-- ... existing template content ...

      <div class="mb-4">
        <el-cascader
          @focus="$refs.nodeCascaderRef.focus()"
          :options="variableOptions"
          ref="nodeCascaderRef"
          :nodeModel="nodeModel"
          class="w-full"
          v-model="condition.field"
          :placeholder="$t('views.applicationWorkflow.variable.placeholder')"
        />
      </div>

      <el-button link type="primary" @click="addBranch">
        <el-icon class="mr-4"><Plus /></el-icon> {{ $t('views.applicationWorkflow.nodes.conditionNode.addBranch') }}
      </el-button>
    </el-form>
  </NodeContainer>
</template>

<script>
export default {
  data() {
    return {
      variableOptions: [], // Initialize options array

      branches: [], // Assume you have a branches array

      condition: {},
    };
  },
  methods: {
    addBranch() {
      if (Array.isArray(this.branches)) {
        this.branches.push({}); // Add new branch object
      } else {
        this.branches = [{ value: '', compare: '==' }]; // Alternatively, initialize array or single branch
      }
    },
  },
};
</script>

By making these adjustments, you reduce redundancy and enhance readability while keeping the codebase maintainable.

Expand Down
Loading