fix: Fix the problem of failed backup of all databases for cronjob #8990
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -315,7 +315,7 @@ func loadDbsForJob(cronjob model.Cronjob) []DatabaseHelper { | |||
| dbs = append(dbs, DatabaseHelper{ | |||
| ID: mysql.ID, | |||
| DBType: cronjob.DBType, | |||
| Database: mysql.Name, | |||
| Database: mysql.Database, | |||
| Name: mysql.Name, | |||
| }) | |||
| } | |||
There was a problem hiding this comment.
The code looks correct and optimized with no immediate irregularities or potential issues. The change from mysql.Name to mysql.Database maintains consistency but does not appear necessary unless you have specific requirements that dictate using different names for databases versus IDs. If both columns should be used, the code is already correctly handling this scenario.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refs #8982