Conversation
gabrielcoder247
suggested changes
Aug 16, 2022
gabrielcoder247
left a comment
gabrielcoder247
left a comment
There was a problem hiding this comment.
Hi @1GORDON
Good job so far!
Highlights!
- Followed Gitflow ✔️
- Good commit messages ✔️
- Descriptive Pull request ✔️
- Professional readme ✔️
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻️⛔️
- I noticed your Eslint is not passing the test. Kindly make sure your Eslint passes as this is the requirement for your pull request to be approved
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!:clap::clap::clap:
Feel free to leave any questions or comments in the PR thread and tag me @gabrielcoder247 if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Comment on lines
+38
to
+45
| // export function clearCompleted() { | ||
| // const newTodos = todos.filter((todo) => todo.completed !== true); | ||
| // newTodos.forEach((object, index) => { | ||
| // object.index = index + 1; | ||
| // }); | ||
| // localStorage.setItem('todo', JSON.stringify(newTodos)); | ||
| // window.location.reload(); | ||
| // } No newline at end of file |
There was a problem hiding this comment.
Great Job @1GORDON
- Kindly remove commented code from your project as this is not regarded as a good practice
Comment on lines
+26
to
29
| function changeTaskStatus(index, status) { | ||
| todos.filter((todo, todoIndex) => { | ||
| if (index === todoIndex) { | ||
| todo.completed = status; |
There was a problem hiding this comment.
Great job @1GORDON
- Kindly use ES6 syntax for all your functions and methods as stated in javascript best practices across all your javascript files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Index.html file