Need embed fonts to be optional

[davidburns573]

Our team uses a number of font families that are very large when included in the <style/> tag of the exported svg. This results in image files that are 10000x larger. We would like to optionally disable the embedFonts step of the conversion process.

We've temporarily forked this repo and made our change, but it would be great if we could include this here since others may benefit as well!

Forked repo: https://github.com/davidburns573/dom-to-image-more

[YujiaCheng1996]

Agree! Just can't disable it with current apis.

[IDisposable]

This should be relatively easy. I will dig into that this weekend. Do you have a test example jsfiddle

…

On Thu, Aug 8, 2024, 01:27 YujiaCheng1996 ***@***.***> wrote: Agree! Just can't disable it with current apis. — Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGVMSZM3M4CB2SMFDDZEVTZQMFTPAVCNFSM6AAAAABMFY76G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGA2DMMZTGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[YujiaCheng1996]

This should be relatively easy. I will dig into that this weekend. Do you have a test example jsfiddle
…
On Thu, Aug 8, 2024, 01:27 YujiaCheng1996 @.> wrote: Agree! Just can't disable it with current apis. — Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGVMSZM3M4CB2SMFDDZEVTZQMFTPAVCNFSM6AAAAABMFY76G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGA2DMMZTGY . You are receiving this because you are subscribed to this thread.Message ID: @.>

Doesn't need a test example.
It just adds all the font-face(s) found to the SVG without any means to disable it.
His solution is working.
0c4a634
Just add an option to disable the process or use a more intelligent algorithm to rule out the unrelated font-face(s).

[IDisposable]

That's fine for you, but I need a test suite coverage for any new options. On Thu, Aug 8, 2024 at 8:54 PM YujiaCheng1996 ***@***.***> wrote:

…

This should be relatively easy. I will dig into that this weekend. Do you have a test example jsfiddle … <#m_5585240274510573477_> On Thu, Aug 8, 2024, 01:27 YujiaCheng1996 *@*.*> wrote: Agree! Just can't disable it with current apis. — Reply to this email directly, view it on GitHub <#158 (comment) <#158 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGVMSZM3M4CB2SMFDDZEVTZQMFTPAVCNFSM6AAAAABMFY76G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGA2DMMZTGY <https://github.com/notifications/unsubscribe-auth/AAGVMSZM3M4CB2SMFDDZEVTZQMFTPAVCNFSM6AAAAABMFY76G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVGA2DMMZTGY> . You are receiving this because you are subscribed to this thread.Message ID: @.*> Doesn't need a test example. It just adds all the font-face(s) found to the SVG without any means to disable it. His solution is working. 0c4a634 <0c4a634> Just add an option to disable the process or use a more intelligent algorithm to rule out the unrelated font-face(s). — Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGVMS26E44VAYHAAOJA4HLZQQOMNAVCNFSM6AAAAABMFY76G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGAYDGNRSGA> . You are receiving this because you commented.Message ID: ***@***.***>

-- Marc Brooks http://about.me/IDisposable http://twitter.com/IDisposable

[YujiaCheng1996]

https://jsfiddle.net/fu01mxh7/1/
This shows an example with totally unrelated and huge fonts included in the global CSS.