Fix styles link #3956
Fix styles link #3956
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.eleventy.js
Outdated
| 'aria-hidden="true" role="img">' + | ||
| '<use xlink:href="#svg-lock_outline"></use>' + | ||
| '</svg>' | ||
| content = content.replace('>', `> ${prefixIcon}`); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
.eleventy.js
Outdated
| } | ||
| } | ||
| else { | ||
| content = content.replace('>', ' class="usa-link usa-link--external">'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
.eleventy.js
Outdated
| } | ||
| } | ||
| else { | ||
| content = content.replace('>', ' rel="noreferrer">'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
…eanup since the styles for two sites were combined.
|
Your work here made it apparent for the first time that we've been missing the correct footer content.
So, I've added back the correct footer, but now the category headers aren't looking right
This is just on the border of "scope creep", so I'll leave it to you: do you want to do that fix in this ticket (I can push the footer), or should we open another ticket for that? |
|
I will give a quick check and if it seems like a large lift, I will break it out into its own ticket. Thanks! |
|
My initial investigation shows that all the classes are the same, but for some reason the |
…issues for the updated footer.
|
@beechnut I believe I fixed the issues you highlighted as well as a couple other styling issues for the footer. |
|
I've been trying to review this latest commit, but I'm having trouble even getting styles to render. I think it has something to do with the transient Will continue working on this |
|
|
I fixed the blockquote thing — the Jekyll site was using HTML tags for blockquotes, and changing them to regular markdown fixed the spacing and the rendering. So, just the our-work styles are what's blocking approval. Thanks :) |
|
Thank you! |
|
Turns out the our-work page had no layout specified! Jekyll may have had an implicit default layout, but 11ty seems more explicit. Changing layouts is separate from this story, so we're good here! Approved! |
Pull request summary for #3956
This PR migrates the styles from the live 18f website to the replatformed site. The handling of scss files and their organization were updated. Updated styles are now loading.
Closes #3848.
Reminder - please do the following before assigning reviewer
And make sure that automated checks are ok