Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review - Correct the blog post and blog page templates #3951

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

beechnut
Copy link
Contributor

This commit:

  • Fixes the header, so the title appears
  • Removes unused parts of templates
  • Removes unused filters
  • Renames image_accessibility to image_alt site-wide
  • Sets up partials for images
  • Adjusts image asset paths
  • Incidentally removes a duplicate layout (primary and guides were the same)

Closes #3849

@beechnut beechnut marked this pull request as ready for review June 25, 2024 14:03
@beechnut beechnut requested a review from a team as a code owner June 25, 2024 14:03
@bpdesigns bpdesigns changed the title Correct the blog post and blog page templates Review - Correct the blog post and blog page templates Jun 25, 2024
@janelx janelx assigned janelx and unassigned janelx Jun 25, 2024
Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- love to see the progression. i do wonder however how we are tracking this additional work and suggestions for improvement, if we don't have tickets for this already?

_data/assetPaths.json Outdated Show resolved Hide resolved
_includes/feature-image.html Show resolved Hide resolved
_includes/layouts/default.html Show resolved Hide resolved
_includes/meta.html Show resolved Hide resolved
This commit:

- Fixes the header, so the title appears
- Removes unused parts of templates
- Removes unused filters
- Renames `image_accessibility` to `image_alt` site-wide
- Sets up partials for images
- Adjusts image asset paths
- Incidentally removes a duplicate layout (`primary` and `guides` were the same)
@beechnut beechnut merged commit 8d41085 into replatform-main Jun 26, 2024
5 checks passed
@beechnut beechnut deleted the replatform/post-layout branch June 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants