Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data-fns module #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

anniebock
Copy link
Collaborator

  1. Added date-fns in package.json

added this line: "date-fns": "^2.27.0", under "dependencies"

  1. npm i

@anniebock anniebock requested review from eych and Jnnybrrn May 27, 2022 14:12
@anniebock anniebock changed the title added data-fns module Added data-fns module May 27, 2022
@anniebock
Copy link
Collaborator Author

@Jnnybrrn @eych Just wanted to confirm if this is the correct way to add a new module in the repo.

Copy link

@Jnnybrrn Jnnybrrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the dependency and running npm i is good - but we need to add node_modules/ to the git ignore file.

This PR has loaded all source code for this new module (and it's dependencies) into our git repo which is not what we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants