Skip to content

Sidebar message linkify #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilovecherries wants to merge 4 commits into
base: 🌨️
Choose a base branch
from
Open

Sidebar message linkify #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6965b85
link to page in sidebar
ilovecherries Jul 21, 2022
530301e
added setting for sidebar linkify
ilovecherries Jul 21, 2022
eb92054
changed to manipulate <a> href attribute instead of swapping properties
ilovecherries Jul 22, 2022
12f61cb
what the fuck that's the wrong order
ilovecherries Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions src/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const Sidebar = NAMESPACE({
tabs: null,
$my_avatar: null,
userlist: new StatusDisplay(0, null),
linkify_messages: false,

normal_open: false,
fullscreen_open: false,
Expand Down Expand Up @@ -233,8 +234,13 @@ const Sidebar = NAMESPACE({
link.href = "#user/"+comment.createUserId
link.firstChild.src = Draw.avatar_url(author)
link.lastChild.textContent = name

d.append(comment.text.replace(/\n/g, " "))
let content = d.lastChild
content.setAttribute("page", comment.contentId)
if (Sidebar.linkify_messages) {
content.href = "#page/"+comment.contentId
}
content.setAttribute('aria-disabled', String(!Sidebar.linkify_messages))
content.append(comment.text.replace(/\n/g, " "))

return d
}.bind(𐀶`
Expand All @@ -243,6 +249,8 @@ const Sidebar = NAMESPACE({
<img class='item avatar' width=100 height=100>
<span class='textItem entity-title pre'></span>
</a>:&#32;
<a class='sidebar-message-content'>
</a>
</div>
`),

Expand Down Expand Up @@ -279,3 +287,26 @@ Object.defineProperty(window, 'log', {
})

do_when_ready(x=>Sidebar.onload())

Settings.add({
name: 'linkify_sidebar_messages', label: 'Linkify Sidebar Messages',
type: 'select',
options: ['no', 'yes'],
update(value) {
do_when_ready(() => {
Sidebar.linkify_messages = (value === 'yes')
const contents = document.querySelectorAll('#\\$sidebarBottom .sidebar-message-content')
if (Sidebar.linkify_messages) {
contents.forEach(c => {
c.setAttribute('href', `#page/${c.getAttribute("page")}`)
c.setAttribute('aria-disabled', "false")
})
} else {
contents.forEach(c => {
c.removeAttribute('href')
c.setAttribute('aria-disabled', "true")
})
}
})
},
})
3 changes: 3 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,9 @@ activity-users {
overflow-y: scroll;
width: 100%;
}
#\$sidebarBottom .sidebar-message-content {
color: var(--T-color);
}

/* contain */
#\$sidebarBottom,
Expand Down