Fix table header missing (mozilla#530)

1257mp · Jul 19, 2019 · e1dab15 · e1dab15
1 parent e55ffab
commit e1dab15
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 185 deletions.
diff --git a/Readability.js b/Readability.js
@@ -808,6 +808,7 @@ Readability.prototype = {
         if (stripUnlikelyCandidates) {
           if (this.REGEXPS.unlikelyCandidates.test(matchString) &&
               !this.REGEXPS.okMaybeItsACandidate.test(matchString) &&
+              !this._hasAncestorTag(node, "table") &&
               node.tagName !== "BODY" &&
               node.tagName !== "A") {
             this.log("Removing unlikely candidate - " + matchString);

diff --git a/test/test-pages/keep-tabular-data/expected-metadata.json b/test/test-pages/keep-tabular-data/expected-metadata.json
@@ -1,7 +1,8 @@
 {
   "title": "Friday Facts #282 - 0.17 in sight | Factorio",
   "byline": null,
+  "dir": null,
   "excerpt": "Posted by kovarex, TOGos, Ernestas, Albert on 2019-02-15, all posts",
-  "readerable": true,
-  "siteName": "Factorio.com"
+  "siteName": "Factorio.com",
+  "readerable": true
 }