Skip to content

warning when custom coverage is above or equal to global coverage #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

warning when custom coverage is above or equal to global coverage #43

merged 2 commits into from
Oct 31, 2024

Conversation

anne-gaelle123inkt
Copy link
Contributor

@anne-gaelle123inkt anne-gaelle123inkt commented Oct 30, 2024

Changed the condition checking if the custom coverage entry is useless, to make it also raise an error when the custom coverage is equal to the global coverage
Also fixed a UT issue

@anne-gaelle123inkt anne-gaelle123inkt requested a review from a team as a code owner October 30, 2024 11:21
@anne-gaelle123inkt anne-gaelle123inkt changed the title B#187800 PHPFCI: warning when custom coverage is above or equal to gl… warning when custom coverage is above or equal to global coverage Oct 30, 2024
@frankdekker frankdekker merged commit 0eaf0bc into 123inkt:master Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants