Skip to content

Make return type of AbstractControllerTestCase compatible with phpunit #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 31, 2025
Merged

Make return type of AbstractControllerTestCase compatible with phpunit #24

merged 17 commits into from
Mar 31, 2025

Conversation

frankdekker
Copy link
Member

@frankdekker frankdekker commented Mar 30, 2025 •
edited
Loading

Fixes:

  • PHPUnit changed namespace of InvocationMocker and the interfaces in PHPUnit 12. Added support for both interfaces. Had to add placeholders for phpstan to understand the interfaces of the return types.
  • narrowed consecutive return type so it never returns string keyed array.

@frankdekker frankdekker requested a review from bram123 March 30, 2025 14:45
@frankdekker frankdekker merged commit d380a87 into master Mar 31, 2025
16 checks passed
@frankdekker frankdekker deleted the Fix-invocation-mocker-return-type branch March 31, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram123 bram123 bram123 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankdekker @bram123