Remove dependency on object.entries to make 11ty leaner
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer necessary - 11ty already requires a recent enough NodeJS that it's safe to assume `Object.entries` exists.
|
Oh, wild. I was going to ship this as a breaking change but it looks like Regardless, this is a great find. I’m going to ship it with v1.0.1 of this plugin |
|
v1.0.1 shipped, will be included with core v3.0.1 (-alpha.4 or newer) |
|
Required https://github.com/11ty/eleventy-plugin-rss/releases/tag/v2.0.3 too, posthtml-urls was previously pinned to 1.0.0 there |
zachleat
added a commit
to 11ty/eleventy
that referenced
this pull request
Jan 16, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
object.entriesshim is not necessary - even 11ty version 1x requires a recent enough NodeJS that it's safe to assumeObject.entriesexists. Tests are only run on Node 18 and 20 anyway, and the dependency is only used in the test.js file.Removing this dependency would get rid of the longest branch in 11ty's dependency tree. This reduces the risk of supply chain attacks, makes installs faster and is better for the environment.
https://npmgraph.js.org/?q=%4011ty%2Feleventy#zoom=w&select=exact%3Aobject.entries%401.1.8