Skip to content

Fix irrelevant duplicate data mixin #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igk1972
Copy link
Contributor

@igk1972 igk1972 commented Jan 4, 2021

Fix problem after merge multiple data objects (with different keys).

The problem occurs when you use pagination on pages where some fields are missing.
Vue merges multiple data mixins, so the data contains irrelevant fields.

Fix problem after merge multiple data objects (with different keys).
@zachleat
Copy link
Member

Ah, can you describe the problem a little bit more? What do you mean multiple data objects? I’d love to get a test around this before I merge

@igk1972
Copy link
Contributor Author

igk1972 commented Feb 15, 2021

Ah, can you describe the problem a little bit more? What do you mean multiple data objects? I’d love to get a test around this before I merge

Short.
When we use pagination on pages, then vue-component rendered many times and many places. But data object may be empty.
See https://github.com/11ty/eleventy-plugin-vue/blob/master/EleventyVue.js#L323

I will to create special repository example. Later, on this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants