Fix unhandled exception in request handling crashes the process - #153
Open
iaohkut-from-NightWolf-Team wants to merge 1 commit into
Open
Conversation
…248/400)
getOutputDirFilePath() throws Error("Invalid path") as its normal rejection
path for an out-of-bounds request, but nothing in the call chain up to the
raw http.Server request handler caught it, so the exception propagated as
an unhandled promise rejection (onRequestHandler is async) and terminated
the entire Node.js process on a single crafted GET request.
Wrap the middleware-chain invocation in onRequestHandler in a try/catch and
respond with a normal 400 instead of letting the exception escape. Verified
against the existing test suite (32/32 passing) plus a PoC that previously
killed the server with one request and now returns 400 while the server
stays alive for subsequent requests.
Co-Authored-By: iaohkut <thb2601@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150.
Summary
getOutputDirFilePath()throwsError("Invalid path")as its normal rejection path for an out-of-bounds request, but nothing in the call chain up to the rawhttp.Serverrequest handler caught it. SinceonRequestHandlerisasync, the thrown error becomes a rejected promise with no.catch()attached by the caller — an unhandled rejection that terminates the entire Node.js process on a single crafted GET request.Fix
Wrap the middleware-chain invocation in
onRequestHandlerin a try/catch and respond with a normal 400 instead of letting the exception escape:Verification
See #150 for the full report and original reproduction.