Add test coverage to handler and return sequence classes #219
Conversation
| */ | ||
| public static function handleFunction(string $functionName, array $args = []) | ||
| { | ||
| if (self::handlerExists($functionName)) { |
There was a problem hiding this comment.
what do you think about using stattic:: instead of self::?
There was a problem hiding this comment.
I actually just moved this class from its original into a namespace and did not alter its contents
php/WP_Mock/Functions/Handler.php
Outdated
| throw $exception; | ||
| } | ||
|
|
||
| $result = ob_get_clean() ?: ''; |
There was a problem hiding this comment.
Do you expect the buttfer to be closed at anytime while handling the function? I see the catched expception get thrown right after ending/closing the buffer
There was a problem hiding this comment.
the exception is caught but then thrown again before closing the buffer output
when not thrown, the buffer is captured
There was a problem hiding this comment.
So we don't need the ?: '' in this case right?
| $result = ob_get_clean() ?: ''; | |
| $result = ob_get_clean(); |
There was a problem hiding this comment.
71c133d we can, and maybe it's a good idea to throw an exception if ob_get_clean returns false (not a string)
|
note for reviewers: as for this moment there are some GitHub issues also reported in https://www.githubstatus.com/ where some PR functions in GH are degraded - I'm pushing commits to this PR and they appear to hold in git (via CLI) but they don't show up in this PR and in the GH workflow - you may be able however to |
unfulvio-godaddy
deleted the
chore/add-test-coverage-to-handler-and-return-sequence
branch
Summary
Adds test coverage for the
HandlerandReturnSequenceclasses.These classes were refactored and moved into the
WP_Mock/Functionsnamespace.Even though these methods are internal, it's a minor API break. However, we are considering to tag v1.0.0 soon so it should be acceptable.
The only change is for devs implementing their own function mocks outside of
WP_Mock::userFunction()etc. by directly calling\WP_Mock\Functions\Handler::handleFunction(__FUNCTION__, func_get_args());-- this is documented in the docs.Details
Note: this depends on #216 to be merged first.Contributor checklist
Testing
Reviewer checklist