Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.7.0 #192

Merged
merged 13 commits into from
Apr 5, 2024
Merged

Release 2.7.0 #192

merged 13 commits into from
Apr 5, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Mar 12, 2024 •
edited
Loading

Description of the Change

Release 2.7.0 PR.

Closes #191

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 self-assigned this Mar 12, 2024
@Sidsector9 Sidsector9 removed the request for review from dkotter March 12, 2024 09:26
@github-actions github-actions bot added this to the 2.7.0 milestone Mar 12, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@Sidsector9 Sidsector9 removed the needs:feedback This requires feedback to determine next steps. label Mar 12, 2024
@Sidsector9 Sidsector9 changed the title Release/2.7.0 Release 2.7.0 Mar 12, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Mar 12, 2024
@Sidsector9 Sidsector9 removed the needs:feedback This requires feedback to determine next steps. label Mar 12, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Mar 12, 2024
jeffpaul
jeffpaul requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like version bump still needed in package-lock.json

iamdharmesh
iamdharmesh previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File changes LGTM.

The release date needs to be updated, but it is not a blocker for the release and can be updated after release with follow-up PR.

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires feedback to determine next steps. labels Apr 2, 2024
@Sidsector9 Sidsector9 requested a review from jeffpaul April 2, 2024 10:25
@github-actions github-actions bot added needs:feedback This requires feedback to determine next steps. and removed needs:code-review This requires code review. labels Apr 2, 2024
jeffpaul
jeffpaul approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling the release!

@Sidsector9 Sidsector9 merged commit 94319c7 into develop Apr 5, 2024
13 of 14 checks passed
@Sidsector9 Sidsector9 deleted the release/2.7.0 branch April 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@iamdharmesh iamdharmesh iamdharmesh left review comments

Assignees

@Sidsector9 Sidsector9

Labels
needs:feedback This requires feedback to determine next steps.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

Release 2.7.0
3 participants
@Sidsector9 @jeffpaul @iamdharmesh