Create GitHub JS lint action #136
Conversation
kmgalanakis
force-pushed
the
feature/gh-js-lint-action
branch
6 times, most recently
from
3c017e4 to
2619ccf
Compare
kmgalanakis
force-pushed
the
feature/gh-js-lint-action
branch
from
2619ccf to
3007c58
Compare
jeffpaul
requested review from
a team and
peterwilsoncc
and removed request for
a team and
jeffpaul
| import 'jquery-ui-sortable'; | ||
| import 'jquery'; |
There was a problem hiding this comment.
As the plugin uses @wordpress/dependency-extraction-webpack-plugin, import jquery should work fine and allow us to avoid the need for window.jQuery throughout.
Were you experiencing issues with the import?
There was a problem hiding this comment.
@kmgalanakis could you please respond to Peter's comment above?
There was a problem hiding this comment.
@Sidsector9 want to handle any final updates here so this can get merged in as part of the 2.5.0 release?
There was a problem hiding this comment.
Sorry for the late response @peterwilsoncc and @jeffpaul. I had very limited bandwidth for the past couple of weeks.
To address @peterwilsoncc concern, I modified the eslint configuration to be able to use jQuery without having to do it through window.
This should be good to go @jeffpaul.
Description of the Change
assets/js/src/simple-page-ordering.js(the only active JS project file) to pass the linting tests.Closes #130
How to test the Change
npm run dev, make changes to theassets/js/src/simple-page-ordering.jsthat would generate JS lint errors and verify that the errors are showing in the terminal.assets/js/src/simple-page-ordering.jsthat would generate JS lint errors and runnpm run js-lintand verify that the errors are showing in the terminal.Files changedtab)Changelog Entry
Credits
Props @Sidsector9, @kmgalanakis
Checklist: