Feature/yoast payload optimize #727
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @10up/headless_frameworkThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
124.29 KB (🟡 +10 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
10.44 KB |
134.72 KB | 92.91% (🟡 +0.10%) |
/[...path] |
7.25 KB |
131.54 KB | 90.72% (🟡 +0.05%) |
/author/[...path] |
5.96 KB |
130.24 KB | 89.82% (🟡 +0.09%) |
/blog/[[...path]] |
10.9 KB |
135.19 KB | 93.23% (🟡 +0.12%) |
/category/[...path] |
5.66 KB |
129.94 KB | 89.62% (🟡 +0.04%) |
/search/[[...path]] |
3.66 KB |
127.95 KB | 88.24% (🟡 +0.03%) |
/tag/[...path] |
5.66 KB |
129.95 KB | 89.62% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
124.29 KB (🟡 +10 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
10.44 KB |
134.72 KB | 92.91% (🟡 +0.10%) |
/[...path] |
7.25 KB |
131.54 KB | 90.72% (🟡 +0.05%) |
/author/[...path] |
5.96 KB |
130.24 KB | 89.82% (🟡 +0.09%) |
/blog/[[...path]] |
10.9 KB |
135.19 KB | 93.23% (🟡 +0.12%) |
/category/[...path] |
5.66 KB |
129.94 KB | 89.62% (🟡 +0.04%) |
/search/[[...path]] |
3.66 KB |
127.95 KB | 88.24% (🟡 +0.03%) |
/tag/[...path] |
5.66 KB |
129.95 KB | 89.62% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/wp-nextjs-appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
126.01 KB (🟡 +14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
9.81 KB |
135.81 KB | 93.66% (🟡 +0.10%) |
/[...path] |
6.69 KB |
132.69 KB | 91.51% (🟡 +0.06%) |
/author/[...path] |
6.04 KB |
132.05 KB | 91.07% (🟡 +0.08%) |
/blog/[[...path]] |
10.27 KB |
136.28 KB | 93.99% (🟡 +0.11%) |
/category/[...path] |
5.75 KB |
131.76 KB | 90.87% (🟡 +0.04%) |
/search/[[...path]] |
3.76 KB |
129.77 KB | 89.50% (🟡 +0.02%) |
/tag/[...path] |
5.75 KB |
131.75 KB | 90.86% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
126.01 KB (🟡 +14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
9.81 KB |
135.81 KB | 93.66% (🟡 +0.10%) |
/[...path] |
6.69 KB |
132.69 KB | 91.51% (🟡 +0.06%) |
/author/[...path] |
6.04 KB |
132.05 KB | 91.07% (🟡 +0.08%) |
/blog/[[...path]] |
10.27 KB |
136.28 KB | 93.99% (🟡 +0.11%) |
/category/[...path] |
5.75 KB |
131.76 KB | 90.87% (🟡 +0.04%) |
/search/[[...path]] |
3.76 KB |
129.77 KB | 89.50% (🟡 +0.02%) |
/tag/[...path] |
5.75 KB |
131.75 KB | 90.86% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/wp-nextjs-appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
126.01 KB (🟡 +14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
9.81 KB |
135.81 KB | 93.66% (🟡 +0.10%) |
/[...path] |
6.69 KB |
132.69 KB | 91.51% (🟡 +0.06%) |
/author/[...path] |
6.04 KB |
132.05 KB | 91.07% (🟡 +0.08%) |
/blog/[[...path]] |
10.27 KB |
136.28 KB | 93.99% (🟡 +0.11%) |
/category/[...path] |
5.75 KB |
131.76 KB | 90.87% (🟡 +0.04%) |
/search/[[...path]] |
3.76 KB |
129.77 KB | 89.50% (🟡 +0.02%) |
/tag/[...path] |
5.75 KB |
131.75 KB | 90.86% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/wp-nextjs-appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
126.01 KB (🟡 +14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
9.81 KB |
135.81 KB | 93.66% (🟡 +0.10%) |
/[...path] |
6.69 KB |
132.69 KB | 91.51% (🟡 +0.06%) |
/author/[...path] |
6.04 KB |
132.05 KB | 91.07% (🟡 +0.08%) |
/blog/[[...path]] |
10.27 KB |
136.28 KB | 93.99% (🟡 +0.11%) |
/category/[...path] |
5.75 KB |
131.76 KB | 90.87% (🟡 +0.04%) |
/search/[[...path]] |
3.76 KB |
129.77 KB | 89.50% (🟡 +0.02%) |
/tag/[...path] |
5.75 KB |
131.75 KB | 90.86% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/wp-nextjs-appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
There was a problem hiding this comment.
This is looking good! Just left one comment about a potential edge case, can you add a test for when slug is passed and it might return multiple posts with different parents.
Also please add a changeset for @headstartwp/core and @headstartwp/headstartwp
| $this->optimise_yoast_payload_for_author( $post_obj['_embedded']['author'], $request, $first_post ); | ||
| } | ||
|
|
||
| if ( ! $first_post ) { |
There was a problem hiding this comment.
There's one edge case: if the request contains slug it might return multiple results withmultiple posts sharing the same slug but be under different parents, and that is resolved on the front-end via post path matching.
I think if slug is set we should not unset yoast_head and yoast_head_json for any of the results, so I think you can simply check if slug it not set here.
There was a problem hiding this comment.
I have pushed the change @nicholasio also pushed a change to set 'up' embeddable as false so it doesn't attempt to get the data for parent posts 246fed9
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
126.01 KB (🟡 +14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
9.81 KB |
135.81 KB | 93.66% (🟡 +0.10%) |
/[...path] |
6.69 KB |
132.69 KB | 91.51% (🟡 +0.06%) |
/author/[...path] |
6.04 KB |
132.05 KB | 91.07% (🟡 +0.08%) |
/blog/[[...path]] |
10.27 KB |
136.28 KB | 93.99% (🟡 +0.11%) |
/category/[...path] |
5.75 KB |
131.76 KB | 90.87% (🟡 +0.04%) |
/search/[[...path]] |
3.76 KB |
129.77 KB | 89.50% (🟡 +0.02%) |
/tag/[...path] |
5.75 KB |
131.75 KB | 90.86% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/wp-nextjs-appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
|
@lucymtc can you also handle |
📦 Next.js Bundle Analysis for @10up/headstartwpThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
126.01 KB (🟡 +14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (145 KB) |
|---|---|---|---|
/ |
9.81 KB |
135.81 KB | 93.66% (🟡 +0.10%) |
/[...path] |
6.69 KB |
132.69 KB | 91.51% (🟡 +0.06%) |
/author/[...path] |
6.04 KB |
132.05 KB | 91.07% (🟡 +0.08%) |
/blog/[[...path]] |
10.27 KB |
136.28 KB | 93.99% (🟡 +0.11%) |
/category/[...path] |
5.75 KB |
131.76 KB | 90.87% (🟡 +0.04%) |
/search/[[...path]] |
3.76 KB |
129.77 KB | 89.50% (🟡 +0.02%) |
/tag/[...path] |
5.75 KB |
131.75 KB | 90.86% (🟡 +0.04%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
📦 Next.js Bundle Analysis for @10up/wp-nextjs-appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
2 participants
Description of the Change
Optimize Yoast payload response ensuring only necessary Yoast data is added to the elements in _embedded that are needed.
Closes #563
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: