fix: Replace deprecated set-output command#108
Merged
Conversation
Member
|
Probably worth checking if this same update needs to be made in the readme/asset update action as well. |
Contributor
Author
|
dkotter
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
GitHub has deprecated the
set-outputandsave-statecommands. This PR updatesdeploy.shto use the suggested replacement.How to test the Change
Do a test deployment with
generate-zipset totrue. Observe that thezip-pathoutput is present.Changelog Entry
Fixed: Replaced the deprecated
set-outputcommand with redirection to$GITHUB_OUTPUTCredits
Props @sjinks
Checklist: