Skip to content

fix: Replace deprecated set-output command#108

Merged
jeffpaul merged 2 commits into
10up:developfrom
sjinks:fix-set-output
Oct 17, 2022
Merged

fix: Replace deprecated set-output command#108
jeffpaul merged 2 commits into
10up:developfrom
sjinks:fix-set-output

Conversation

@sjinks
Copy link
Copy Markdown
Contributor

@sjinks sjinks commented Oct 14, 2022

Description of the Change

GitHub has deprecated the set-output and save-state commands. This PR updates deploy.sh to use the suggested replacement.

How to test the Change

Do a test deployment with generate-zip set to true. Observe that the zip-path output is present.

Changelog Entry

Fixed: Replaced the deprecated set-output command with redirection to $GITHUB_OUTPUT

Credits

Props @sjinks

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.2.0 milestone Oct 14, 2022
@jeffpaul jeffpaul requested review from a team, cadic and dkotter and removed request for a team October 14, 2022 14:56
@jeffpaul
Copy link
Copy Markdown
Member

Probably worth checking if this same update needs to be made in the readme/asset update action as well.

@sjinks
Copy link
Copy Markdown
Contributor Author

sjinks commented Oct 14, 2022

  • README.md looks good - there is no ::set-output there;
  • release-pull-request.yml - updated.

Copy link
Copy Markdown

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjinks thanks for the update, LGTM.
I've approved the test workflow to run on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants