-
Notifications
You must be signed in to change notification settings - Fork 36
Open
Labels
help wantedExtra attention is neededExtra attention is neededneeds:discussionThis requires discussion to determine next steps.This requires discussion to determine next steps.needs:engineeringThis requires engineering to resolve.This requires engineering to resolve.type:enhancementNew feature or request.New feature or request.
Milestone
Description
Is your enhancement related to a problem? Please describe.
Right now the deploy script returns error code if other files have been modified (which actually not an issue). This triggers email notification about the failed GitHub Action.
action-wordpress-plugin-asset-update/deploy.sh
Lines 120 to 129 in 380f651
| if [[ -z $(svn stat) ]]; then | |
| echo "🛑 Nothing to deploy!" | |
| exit 0 | |
| # Check if there is more than just the readme.txt modified in trunk | |
| # The leading whitespace in the pattern is important | |
| # so it doesn't match potential readme.txt in subdirectories! | |
| elif svn stat trunk | grep -qvi " trunk/$README_NAME$"; then | |
| echo "🛑 Other files have been modified; changes not deployed" | |
| exit 1 | |
| fi |
Describe the solution you'd like
Could we exit with code 0 same as "Nothing to deploy" case?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is neededneeds:discussionThis requires discussion to determine next steps.This requires discussion to determine next steps.needs:engineeringThis requires engineering to resolve.This requires engineering to resolve.type:enhancementNew feature or request.New feature or request.
Type
Projects
Status
To Do