Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty js file output from css entry #91

Merged
merged 2 commits into from
Jul 25, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Jul 21, 2021

Description of the Change

This change adds the plugin webpack-remove-empty-scripts to remove empty scripts generated when we have CSS entries.

Alternate Designs

Benefits

It's not necessary extending the webpack config to remove empty scripts.

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #90

Changelog Entry

Fixed empty scripts output when a CSS entry is added.

@Rahmon Rahmon self-assigned this Jul 21, 2021
@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@Rahmon Rahmon requested a review from nicholasio July 21, 2021 14:56
@nicholasio nicholasio added this to the 10up-toolkit@1.0.10 milestone Jul 23, 2021
@nicholasio nicholasio merged commit 789ddee into develop Jul 25, 2021
@nicholasio nicholasio deleted the fix/empty-js-file-output-from-css-entry branch July 25, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty js file output from css entry
2 participants