[TECH] Met à jour ember-cli-notifications pour corriger les tests dans le navigateur#6209
Merged
pix-service-auto-merge merged 1 commit intodevfrom May 15, 2023
Merged
Conversation
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
Alexandre-Monney
approved these changes
May 15, 2023
Contributor
Alexandre-Monney
left a comment
Alexandre-Monney
left a comment
There was a problem hiding this comment.
👍 Tout est ok. Merci François 😸
francois2metz
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
orga-update-ember-cli-notification
branch
from
ce46b64 to
88c89df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les tests de pix orga qui testent les notifications sont systématiquement en erreur lorsqu'on les lance via le navigateur.
🤖 Proposition
Utiliser une version de ember-cli-notification qui corrige ce problème (en attendant un patch sur embroider).
🌈 Remarques
mansona/ember-cli-notifications#360
💯 Pour tester
Lancer les tests dans le navigateurs (/tests) et voir qu'ils sont vert.
Voir la RA et constater que les notifications s'affichent correctement et disparaissent au bout de 5s.