Skip to content

Refactor else / elif when if block has a raise statement #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor else / elif when if block has a raise statement #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drfaddons/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def get_jwt_value(self, request):
msg = _("Invalid Authorization header. No credentials provided.")
raise exceptions.AuthenticationFailed(msg)

elif len(auth) > 2:
if len(auth) > 2:
msg = _(
"Invalid Authorization header. Credentials string "
"should not contain spaces."
Expand Down
4 changes: 2 additions & 2 deletions drfaddons/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,15 +237,15 @@ def send_message(
if not len(recip) > 0:
raise ValueError("No recipient to send message.")
# Check if the value of recipient is valid (min length: a@b.c)
elif len(recip[0]) < 5:
if len(recip[0]) < 5:
raise ValueError("Invalid recipient.")

# Check if all recipient in list are of same type
is_email = validate_email(recip[0])
for ind in range(len(recip)):
if validate_email(recip[ind]) is not is_email:
raise ValueError("All recipient should be of same type.")
elif not is_email:
if not is_email:
recip[ind] = get_mobile_number(recip[ind])

# Check if fallback email is indeed an email
Expand Down