Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new public iter_matching_types function that returns an iterator of matching types, refactoring the existing matching_types function to use it internally. This provides users with a lazy evaluation option when they don't need all matching types materialized into a tuple.
- Adds
iter_matching_typesas a new public API that returns an iterator - Refactors
matching_typesto delegate toiter_matching_types - Renames internal helper
_is_noneto_is_none_typefor clarity - Removes skipped tests and cleans up pytest configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| type_analyzer/_core/matching_types.py | Adds iter_matching_types function, refactors matching_types to use it, renames _is_none to _is_none_type, makes config parameter required in _iter_matching_types |
| type_analyzer/init.py | Exports new iter_matching_types function in public API |
| tests/core/test_matching_types.py | Removes skipped tests and unused imports |
| pyproject.toml | Removes pytest temporary path retention configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.