Skip to content

feat: Add iter_matching_types function#5

Merged
remimd merged 1 commit into
devfrom
iter
Nov 22, 2025
Merged

feat: Add iter_matching_types function#5
remimd merged 1 commit into
devfrom
iter

Conversation

@remimd
Copy link
Copy Markdown
Member

@remimd remimd commented Nov 22, 2025

No description provided.

@remimd remimd requested a review from Copilot November 22, 2025 09:43
@remimd remimd self-assigned this Nov 22, 2025
@remimd remimd merged commit 6f8d5dd into dev Nov 22, 2025
7 checks passed
@remimd remimd deleted the iter branch November 22, 2025 09:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new public iter_matching_types function that returns an iterator of matching types, refactoring the existing matching_types function to use it internally. This provides users with a lazy evaluation option when they don't need all matching types materialized into a tuple.

  • Adds iter_matching_types as a new public API that returns an iterator
  • Refactors matching_types to delegate to iter_matching_types
  • Renames internal helper _is_none to _is_none_type for clarity
  • Removes skipped tests and cleans up pytest configuration

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
type_analyzer/_core/matching_types.py Adds iter_matching_types function, refactors matching_types to use it, renames _is_none to _is_none_type, makes config parameter required in _iter_matching_types
type_analyzer/init.py Exports new iter_matching_types function in public API
tests/core/test_matching_types.py Removes skipped tests and unused imports
pyproject.toml Removes pytest temporary path retention configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants