Conversation
…DeferredDispatcher
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to improve naming consistency by renaming DeferredBus to DeferredDispatcher and consolidating related interfaces.
- Renames
DeferredBustoDeferredDispatcheracross the codebase - Moves
DeferredDispatcherprotocol definition from a standalone file to the base dispatcher module - Updates FastAPI integration to use the new naming convention and adds
use_cache=Falseto dependency configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cq/ext/fastapi.pyi | Removes old type definitions file |
| cq/ext/fastapi.py | Updates FastAPI integration with new naming and adds proper type checking blocks |
| cq/_core/dispatcher/bus.py | Reorders abstract methods in Bus protocol |
| cq/_core/dispatcher/base.py | Adds DeferredDispatcher protocol definition |
| cq/_core/defer.py | Removes old DeferredBus protocol file |
| cq/init.py | Updates exports to use new DeferredDispatcher naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.