Add optional authority-keypair to publish #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsouravm
reviewed
Sep 11, 2025
src/commands/publish.rs
Outdated
| // Load authority keypair | ||
| let spinner = CliProgress::new_spinner("Loading authority keypair..."); | ||
| let authority_keypair = load_keypair_from_file(&config.program.authority_keypair)?; | ||
| let authority_keypair = if let Some(ak) = authority_keypair_arg { |
There was a problem hiding this comment.
Perhaps a match statement would be cleaner?
let authority_keypair = match authority_keypair_arg {
Some(ak) => load_keypair_from_file(ak.trim())?,
None => load_keypair_from_file(&config.program.authority_keypair)?,
};
There was a problem hiding this comment.
You're right, I based my changes off auth.rs
|
Everything else lgtm! |
0xsouravm
reviewed
Sep 11, 2025
| let spinner = CliProgress::new_spinner("Loading authority keypair..."); | ||
| let authority_keypair = load_keypair_from_file(&config.program.authority_keypair)?; | ||
| let authority_keypair = match authority_keypair_arg { | ||
| Some(ak) => load_keypair_from_file(ak.trim())?, |
There was a problem hiding this comment.
If we are checking for an empty path in the config keypair path, I think we should also check for the argument keypair path.
- Get authority keypair path from either argument or config
- Check if it is empty
- Throw error if empty, else proceed to load and assign to
authority_keypair
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
Let me know if there's any feedback