Conversation
ScreamingHawk
requested changes
Aug 21, 2025
| guard: new Guard(shared), | ||
| guard: shared.sequence.guardUrl | ||
| ? new Guard.Sequence.GuardSigner(shared.sequence.guardUrl, shared.sequence.guardAddress) | ||
| : new Guard.Local.GuardSigner(Secp256k1.randomPrivateKey()), |
Contributor
There was a problem hiding this comment.
Can we support a fixed local key? Maybe as another env var. Otherwise the guard will be different every time you restart the app making local dev harder.
| } | ||
| const signedEnvelope = Envelope.toSigned(envelope, [sapientSignature]) | ||
|
|
||
| // TODO: check whether guard signature is even needed for this wallet based on the topology |
Contributor
There was a problem hiding this comment.
Remove comment. I think this if statement is sufficient.
| this.walletAddress = implicitSession?.walletAddress || explicitSessions[0]?.walletAddress || null | ||
| this.loginMethod = result[0]?.loginMethod || null | ||
| this.userEmail = result[0]?.userEmail || null | ||
| this.guard = implicitSession?.guard || explicitSessions[0]?.guard |
Contributor
There was a problem hiding this comment.
Probably fine but could do || explicitSessions.find(s => !!s.guard)?.guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@0xsequence/guard(where it should've been)signEnvelopemethod on SessionManager that adds a guard signature if needed