Skip to content

Add functions to get networks by ChainID and name #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add functions to get networks by ChainID and name #320

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f2b76e
Add functions to get networks by ChainID and name
klaidliadon Nov 20, 2025
0455ef7
Refactor network retrieval functions to methods
klaidliadon Nov 20, 2025
136744d
Remove unnecessary blank line in GetByChainID
klaidliadon Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/networks/networks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,17 @@ func (n Networks) EthProvidersConfig() ethproviders.Config {

return res
}

func (n Networks) GetByChainID(chainID uint64) *Network {
for _, network := range n {
if network.ChainID == chainID {
return network
}
Copy link
Contributor

@VojtechVitek VojtechVitek Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't Networks a map? I think we can look up items directly

Copy link
Contributor

@VojtechVitek VojtechVitek Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

item, ok := n[chainID]
return item, ok

}
return nil
}

func (n Networks) GetByName(name string) *Network {
Copy link
Contributor

@VojtechVitek VojtechVitek Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please return boolean too

network, _ := n[name]
return network
}
Loading