Example nix-based CI workflow #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakzale
force-pushed
the
jakub/nix
branch
2 times, most recently
from
7d6d520 to
d3108a7
Compare
added 6 commits
February 7, 2024 10:43
Bumps nightly to get a fresh cache key
spiral-ladder
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
@jakzale ran me through the code in a pair programming session. LGTM
|
@Daniel-Aaron-Bloom, do you think we need to cache |
The point of the cache is to reduce CI times. Downloading and installing the toolchain takes quite a bit of time. I am a nix idiot so I probably need to sync with you to answer this question properly. |
matthiasgoergens
added a commit
that referenced
this pull request
Feb 19, 2024
This reverts commit 7676cbf.
matthiasgoergens
added a commit
that referenced
this pull request
Feb 19, 2024
This reverts commit 7676cbf.
matthiasgoergens
added a commit
that referenced
this pull request
Feb 19, 2024
jakzale
pushed a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nix to install toolchain dependencies.
We add flake.nix with a devShell that specifies all dependencies needed to build the repository. Rust toolchain version is pulled from rust-toolchain.toml, so people can still use their rustup-based usual workflow.
The only friction point is that we need to instrument Rust linker where to find dynamic libraries, because proc macros seem to be compiled with libstd dynamically linked.
Finally, there are some general improvements to our CI