Mozak-loader tests based on empty-elf #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reshmem
changed the title
matthiasgoergens
added a commit
that referenced
this pull request
Jan 10, 2024
Tiny PR, to help with mozak-loader testing (part of #1049) Co-authored-by: Matthias Görgens <matthias.goergens@mozak.com>
| fn test_empty_elf_check_assumed_values() { | ||
| // This test ensures mozak-loader & mozak-linker-script is indeed aligned | ||
| let mozak_ro_memory = Program::mozak_load_program( | ||
| mozak_examples::EMPTY_ELF, |
There was a problem hiding this comment.
Does this test only work for EMPTY_ELF? I think it should work for any ELF
There was a problem hiding this comment.
I'm assuming it'd be more tedious to check every ELF that we have, since they might not all share (for eg.) similar run time args?
My understanding of this PR is that this ensures our loader is working as expected, and isn't necessarily a test for ELFs specifically, so an empty one would serve that purpose - we could have a followup PR if necessary?
spiral-ladder
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
LGTM, deferring to @vivekvpandya regarding the ELF comment/conversation
reshmem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/emptyELFrunner/src/elf.rsthat use this empty-elf to checkmozak-loader